Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compile and lint verifications before testing #23224

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Add compile and lint verifications before testing #23224

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
675989f
add compile and lint verifications before testing
musienko-maxim Oct 31, 2024
c20b23d
add change dir commands
musienko-maxim Oct 31, 2024
1970e96
add fetchings dependencies
musienko-maxim Oct 31, 2024
6a532c8
fix syntax errors
musienko-maxim Oct 31, 2024
11b4b9e
remove unnecessry cd command
musienko-maxim Oct 31, 2024
4a3d35e
remove unnecessry cd command and generated folder
musienko-maxim Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ env:
jobs:
pr-check:
runs-on: ubuntu-22.04

defaults:
run:
working-directory: tests/e2e
steps:
- name: Git checkout
uses: actions/checkout@v2
Expand All @@ -48,6 +50,15 @@ jobs:
with:
node-version: '16'

- name: Check compilation errors
run: |
npm ci
npm run tsc

- name: Check lint errors
run: |
npm run lint

- name: Start minikube
id: run-minikube
uses: che-incubator/setup-minikube-action@next
Expand Down Expand Up @@ -92,8 +103,6 @@ jobs:

- name: Run Empty Workspace API test
run: |
cd tests/e2e
npm ci
export TS_PLATFORM=kubernetes &&
export TS_API_TEST_KUBERNETES_COMMAND_LINE_TOOL=kubectl &&
export TS_SELENIUM_VALUE_OPENSHIFT_OAUTH=false &&
Expand All @@ -109,7 +118,6 @@ jobs:
run: |
# for saving disk space we can remove the assembly folder because it is legacy code
rm -rf assembly
cd tests/e2e
docker build -t quay.io/eclipse/che-e2e:"${{ env.pr_number }}" -f build/dockerfiles/Dockerfile .

# we have already ran API test, built test image and do not need e2e test-code, remove for saving disk space
Expand Down
Loading