Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing ECA signature #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RamziKaroui
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamziKaroui the macos .DS_Store files should not be checked into git, may you can remove this file?

find_package(Idlpp-cxx REQUIRED)
find_package(CycloneDDS REQUIRED)

if (NOT TARGET CycloneDDS_CXX_API::ddscxx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamziKaroui may you can update the cmake file, the target is not called ..._API anymore. May you can update the code with the current master?

#include <iostream>
#include "dds/dds.hpp"
#include "dds/core/ddscore.hpp"
#include "ATCDataModel_DCPS.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamziKaroui may you can update the source code too for the current master. There is no _DCPS anymore.
And no need to include dds/core/ddscore, its already included in dds/dds.hpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants