Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity fixes #454

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

reicheratwork
Copy link
Contributor

Fixes for the following reported coverity issues:

  • fun_call_w_exception
  • copy_constructor_call
  • dead_error_line

Added try/catch blocks around the code in the example programs

Signed-off-by: Martijn Reicher <[email protected]>
Fixes involve either using std::move or passing variable by const ref

Signed-off-by: Martijn Reicher <[email protected]>
Fixed according to coverity suggestion: made variable const

Signed-off-by: Martijn Reicher <[email protected]>
Fixed this by adding coverity code that this error is intentional
As fixing this will only make the code generator more complex, and any
optimization of the compiler will eliminate that part of the code

Signed-off-by: Martijn Reicher <[email protected]>
Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @reicheratwork !

@eboasson eboasson merged commit 0ddd39b into eclipse-cyclonedds:master Sep 27, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants