Fix issue #457 #459
Merged
Fix issue #457 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue of comparison operators not returning true for unions with default cases not associated with a type for said default case Also added unittests for union comparison operators Signed-off-by: Martijn Reicher <[email protected]>
eboasson
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
LGTM, thanks @reicheratwork !
@jordanLatta155 it'd be great if you could confirm it works for you as well 🙂
|
@reicheratwork, @eboasson, confirmed that this worked for me. Additionally, adding the default case to the switch statements fixed another issue I had where warnings were triggered from not handling all possible cases. Thanks for the quick turnaround! |
|
Thanks @jordanLatta155 Successful CI run with the updated CI build settings: https://dev.azure.com/eclipse-cyclonedds/cyclonedds-cxx/_build/results?buildId=5351&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of comparison operators not returning true for unions with default cases not associated with a type for said default case
Also added unittests for union comparison operators
This PR will fail the Ubuntu + Clang builds until this #458 PR has been merged.
@jordanLatta155 , could you give this one a look please?