Repair crash when event comes between default listener set and enable() called. (#493) #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruoruoniao
force-pushed
the
master
branch
2 times, most recently
from
493cf56
to
e18a502
Compare
|
Thank you so much for providing a fix. As you noted on #493 it is a bit less elegant than you would like, and I agree with that. I've done some investigation and I believe I have a more elegant solution in #495. I'm inclined to go with that one, but perhaps you'd like to have a look and verify that it solves the problem for you as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See detail in #493