Do not throw an exception on times before 19700101 #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops throwing the C++ wrapper from throwing an exception in the dds:core::Time class on trying to construct a time stamp prior to the 00:00:00 UTC on 1 January 1970. There is no reason to do that and it makes it vulnerable to receiving samples with earlier time stamps. Signed-off-by: Erik Boasson <[email protected]>
noxpardalis
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
This seems fine to me in principal and since Cyclone DDS (Core) prevents writing with such invalid timestamps and can handle receiving them it makes sense to propagate the handle of this to the Core. Being liberal in what we consume and conservative in what we produce and all that.
However, from an internal discussion I think some more work might be needed in the back and forth mapping between the Core and C++ bindings' notions of invalid timestamps (i.e. DDS_TIME_INVALID and DDSI_TIME_INVALID for the Core).
Approving this as it fixes an issue now and another PR/investigation can be done to fixup/confirm the mapping of timestamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops throwing the C++ wrapper from throwing an exception in the dds:core::Time class on trying to construct a time stamp prior to the 00:00:00 UTC on 1 January 1970. There is no reason to do that and it makes it vulnerable to receiving samples with earlier time stamps.
It is tricky to test: Cyclone won't allow writing these. I've tested it in a rather convoluted manner by hand ...