Merge pull request #133 from willstott101/bugfix/revert-circles

Revert "Don't rely on the _entities dictionary in the Entity finalizer."
eclipse-cyclonedds · Aug 23, 2022 · 65cb2aa · 65cb2aa
2 parents 40cf316 + fa3bb98
commit 65cb2aa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/cyclonedds/core.py b/cyclonedds/core.py
@@ -187,10 +187,10 @@ def __init__(self, ref: int, listener: "Listener" = None) -> None:
         self._listener = listener
 
     def __del__(self) -> None:
-        if not hasattr(self, "_ref"):
+        if not hasattr(self, "_ref") or self._ref not in self._entities:
             return
 
-        self._entities.pop(self._ref, None)
+        del self._entities[self._ref]
         self._delete(self._ref)
 
     def get_subscriber(self) -> Optional["cyclonedds.sub.Subscriber"]: