support py3.11 and py3.12 #248
Conversation
There was a problem hiding this comment.
Thanks @LY1806620741, you're right, the CI and release build setup for the Python binding really needs updating to current versions. It is so woefully behind because I'm no Python user myself and so I tend to postpone updating CI stuff for it ...
In any case, your proposal is not quite right yet, but I think it is quite close. Let's try to make this happen.
| @@ -53,15 +53,30 @@ jobs: | |||
| 'Ubuntu 22.04 LTS with Python 3.11': | |||
| image: ubuntu-22.04 | |||
| python-version: "3.11" | |||
| 'Ubuntu 22.04 LTS with Python 3.12': | |||
There was a problem hiding this comment.
I am all in favour of adding 3.11 and 3.12, but I think it makes more sense to look at it as updating the set of Python versions run by the CI. I think makes very little sense to keep all the old versions. Surely 3.7 can be dropped by now? (I'm not enough of a Python user to have a good sense for which versions we should keep ...)
There was a problem hiding this comment.
I think the new version can only focus on Python 3.9 above
There was a problem hiding this comment.
Yesterday I installed Centos7, and found the latest rpm package is Python 3.6.This means that there may some people still using the old version
pyproject.toml
Outdated
| @@ -26,7 +26,7 @@ test-command = "pytest -s --verbose {package}/tests" | |||
| test-extras = ["dev"] | |||
|
|
|||
| before-all = [ | |||
| "git clone --branch master --depth 1 https://github.com/eclipse-cyclonedds/cyclonedds.git main", | |||
| "git clone --branch releases/0.10.x --depth 1 https://github.com/eclipse-cyclonedds/cyclonedds.git", | |||
There was a problem hiding this comment.
We mustn't change the core cyclonedds repo branch to releases/0.10.x on the master branch of the Python binding!
There was a problem hiding this comment.
I think that we needed to add version 0.10.2 for cyclonedds-python, but there was a change in the main branch of C development. In fact, it is already a new version, so I am a bit confused about what to do
There was a problem hiding this comment.
I saw a bug in the main branch of Cyclonedds C version 0.10.3, which caused the build to fail, see https://dev.azure.com/eclipse-cyclonedds/cyclonedds-python/_build/results?buildId=6119&view=results
There was a problem hiding this comment.
It is possible to update and wait for a stable version of 0.10.3 before building a more secure one
There was a problem hiding this comment.
@eboasson hi, I build python 3.11+ version for cyclonedds-python0.10.2、cyclonedds0.10.2, Can you confirm and upload it to the pypi library? The build script is open source, and the entire execution is in the github container. I tested that it is available on both windows and linux.
https://github.com/LY1806620741/unitree_sdk2_python/actions/runs/9350099214
| @@ -50,7 +50,7 @@ before-build = [ | |||
|
|
|||
| # By default there is no repair command on windows set, use delvewheel | |||
| repair-wheel-command = [ | |||
| "pip install delvewheel==0.0.18", | |||
| "pip install delvewheel==1.6.0", | |||
There was a problem hiding this comment.
0.0.18 to 1.6.0 ... I think I should try to understand what delvewheel does before merging this 🤔
There was a problem hiding this comment.
Delvewheel is a command-line tool that modifies Python wheel packages and injects dependency dynamic libraries to make them independently bundled.
I built the Windows x64 version on my GitHub pipeline and it looks fine.
https://github.com/LY1806620741/unitree_sdk2_python/blob/37967b640de394992fc7bf06147daf856213a38b/.github/workflows/python-package.yml#L48
In the end, it injected a complete DLL file. see https://github.com/LY1806620741/unitree_sdk2_python/releases/tag/3.11
well, delvewheel 0.0.18 supports up to Python 3.9.see https://pypi.org/project/delvewheel/0.0.18/
at 1.0.0,it Label project as production/stable. https://github.com/adang1345/delvewheel/blob/master/CHANGELOG.md
try to support py3.11 and py3.12
#221 (comment)