Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential iceoryx release of a null pointer #1471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eboasson
Copy link
Contributor

@eboasson eboasson commented Nov 8, 2022

Error path occurs when deliver_data_network succeeds but deliver_locally fails: in that case, the chunk will have been published by deliver_data_any and the chunk pointer turned into a null pointer, yet dds_write_impl_iox will call iox_pub_release_chunk because it received an error code.

Signed-off-by: Erik Boasson [email protected]

Error path occurs when deliver_data_network succeeds but deliver_locally
fails: in that case, the chunk will have been published by
deliver_data_any and the chunk pointer turned into a null pointer, yet
dds_write_impl_iox will call iox_pub_release_chunk because it received
an error code.

Signed-off-by: Erik Boasson <[email protected]>
Copy link
Contributor

@dpotman dpotman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants