Coverity fix #1478
Open
Coverity fix #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add (void) to ignore return value for fprintf calls which do not use the returned value (for instance in the case of outputting to stderr) Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to ignore return value for printf calls which do not use the returned value Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to ignore return value for dds_delete calls which do not use the returned value Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to ignore return value for ddsrt_hh_add calls which do not use the returned value Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to ignore return value for pthread_setspecific calls which do not use the returned value Signed-off-by: Martijn Reicher <[email protected]>
Moved declaration of variables to beginning of function to avoid issues with branching past their initialization Signed-off-by: Martijn Reicher <[email protected]>
Add setting of pointer freed heap memory to NULL to avoid dereferencing or freeing this block again Signed-off-by: Martijn Reicher <[email protected]>
Add check for buffer creation on heap completing succesfully, if the calloc function does not create a buffer, the function add_union_case will return IDL_RETCODE_NO_MEMORY Signed-off-by: Martijn Reicher <[email protected]>
Moved declaration of variables to beginning of function to avoid issues with branching past their initialization Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to calls to scan_token where the return value is not used Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to calls to cnv_trigraph where the return value in not used Signed-off-by: Martijn Reicher <[email protected]>
Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to calls to get_ch where the return value in not used Signed-off-by: Martijn Reicher <[email protected]>
Add correct cleanup of malloc'ed variable fullname Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to calls to snprintf to ignore return values where they are not used Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to calls to skip_ws to ignore return values where they are not used Signed-off-by: Martijn Reicher <[email protected]>
Add (void) before calls to fputs where the return value is not used Add check on return value for calls to fputs in function printrst in file generate_rst.c Signed-off-by: Martijn Reicher <[email protected]>
Add (void) to calls to strlcpy to explicitly ignore the return value in cases where it goes unused Signed-off-by: Martijn Reicher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a number of code issues as reported by Coverity: