Some backports to 0.10.x #1778
Merged
Some backports to 0.10.x #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of 718e747 minus the test code. It is incorrect to assert that payload should be at least 16 bytes large in for the "pserop" sertype. That condition is only valid if the topic is keyed, because it only supports keys that are exactly 16 bytes large. Instead, for an unkeyed topic, anything size is plausible and it is the deserializer that rejects malformed input. Signed-off-by: Erik Boasson <[email protected]>
When setting a listener, any pending (i.e. unhandled) event received before would not result in an immediate callback. Now the set_listener call also checks for pending events, and invokes the registered callbacks when appropriate. This fix is a prerequisite for #eclipse-cyclonedds/cyclonedds-cxx#410 Signed-off-by: Erik Hendriks <[email protected]>
* Add a "writer batching" QoS This adds a QoS setting to control whether or not a writer does batching without any (possible) dependency on asynchronous publications. Batching means small samples get combined in a single RTPS message, improving performance. This message only gets sent automatically when it is full, and if it is important that the preceding samples are actually sent, then the application code must explicitly flush the batch by call `dds_flush`. Signed-off-by: Erik Boasson <[email protected]> * Better documentation Signed-off-by: Erik Boasson <[email protected]> --------- Signed-off-by: Erik Boasson <[email protected]>
Signed-off-by: Erik Boasson <[email protected]>
|
Please see my comment in eclipse-cyclonedds/cyclonedds-cxx#433 |
eboasson
merged commit 1be07de
into
eclipse-cyclonedds:releases/0.10.x
12 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports
As well as #1767 to get the CI back to life (though that bit is not quite done yet, but at least no longer Conan-related)
It also bumps the version number to 0.10.4, I expect that doing a further patch release would appreciated.