Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the concept of a domain lifecycle state. #1879

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Introduce the concept of a domain lifecycle state. #1879

wants to merge 9 commits into from
+159 −1

Conversation

poetinger
Copy link
Contributor

@poetinger poetinger commented Nov 15, 2023 •
edited
Loading

This PR will:

  • Introduce the concept of a lifecycle state for domains
  • Introduce the ability for a user to transition the lifecycle state
  • Introduce the ability for a user to query the current lifecycle state

Limitations:

  • The only two lifecycle states that will exist, for now, are initialisation and operational
  • The only supported transition is initialisation->operational
  • For now, there is no meaning to the two lifecycle states, but this can/will change in the future
  • For now, the transition and state can only be applied to all domains

@poetinger
introduce the concept of locking in ddsrt
56c82ae
@poetinger
introduce dds_domain_lifecycle
edf2609 
Represents the lifecycle state of the system.
@poetinger
introduce the lifecycle state transition
47b5102 
The only supported operation is transitioning from initialisation to operational.
@poetinger poetinger self-assigned this Nov 15, 2023
@poetinger poetinger added the enhancement Enhance existing functionality label Nov 15, 2023
@poetinger
fix missing enum
03aa97a
@poetinger
introduce dds_get_domain_lifecycle
2d5a319 
Includes a fix for accidental placement of implementation within an
 #ifdef causing havok.
@poetinger poetinger marked this pull request as draft November 15, 2023 13:04
@poetinger
Copy link
Contributor Author

Converted to draft, still needs tests.

@poetinger poetinger marked this pull request as ready for review November 20, 2023 10:43
@poetinger poetinger marked this pull request as draft November 23, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboasson eboasson Awaiting requested review from eboasson

Assignees

@poetinger poetinger

Labels
enhancement Enhance existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@poetinger