Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove well-known from Issuer Metadata API #180

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

mkollenstart
Copy link
Contributor

WHAT

Distinguish Issuer Metadata API based on whether sub-paths are included in the Issuer base URL.
If no sub-path is available, a .well-known must be used. If a sub-path is available, the Issuer Metadata API must be hosted without .well-known and a IssuerMetadataService DID service must be added

Closes #173

How was the issue fixed?

Update Issuance protocol specification and added IssuerMetadataService entry in the JSON-LD context

More context

The Issuer may decide on including the IssuerMetadataService DID service even if it is provided under a well known endpoint, but for the spec its probably better to not include this.

@arnoweiss
Copy link
Contributor

I don't understand why the two cases are needed. The Issuer must publish a did doc anyway, otherwise the Holder won't be able to execute step 8 in the CIP flow. Also, the IssuerService must be added anyway. Shouldn't we just define the issuer metadata endpoint URL relative to the issuer baseUrl that's associated with the IssuerService?

@mkollenstart
Copy link
Contributor Author

I don't understand why the two cases are needed. The Issuer must publish a did doc anyway, otherwise the Holder won't be able to execute step 8 in the CIP flow. Also, the IssuerService must be added anyway. Shouldn't we just define the issuer metadata endpoint URL relative to the issuer baseUrl that's associated with the IssuerService?

Ah yes, I think you're right. Then the only change neccessary would be to change the original /.well-known/vci to /vci. Or perhaps even better to /metadata, to have a clearer API structure.

@mkollenstart mkollenstart changed the title feat: add issuer metadata discovery fix: remove well-known from Issuer Metadata API Feb 20, 2025
Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, let's get another review for this.

@mkollenstart mkollenstart merged commit 63164d9 into eclipse-dataspace-dcp:main Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respecify well-known VCI endpoint
3 participants