Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement dspace:DataAddress transformer #3942

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Feb 29, 2024

What this PR changes/adds

This PR adds a JsonObject[To|From]DataAddressTransformer that uses the dspace serialization format outlined in the
Dataplane Signaling technical document

Why it does that

The signaling API will us the dspace serialization format.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3934

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request dpf Feature related to the Data Plane Framework labels Feb 29, 2024
@paullatzelsperger paullatzelsperger marked this pull request as ready for review March 1, 2024 08:21
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.82609% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.22%. Comparing base (7f20ba5) to head (847ea1f).
Report is 109 commits behind head on main.

Files Patch % Lines
...figuration/SignalingApiConfigurationExtension.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3942      +/-   ##
==========================================
+ Coverage   71.74%   73.22%   +1.48%     
==========================================
  Files         919      946      +27     
  Lines       18457    19057     +600     
  Branches     1037     1082      +45     
==========================================
+ Hits        13242    13955     +713     
+ Misses       4756     4642     -114     
- Partials      459      460       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 8b61731 into eclipse-edc:main Mar 1, 2024
19 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/add_dspace_dataaddress_transformer branch March 1, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpf Feature related to the Data Plane Framework enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Story: add JSON-LD transformers for DataPlane Signaling
4 participants