feat(dsp): transform dspace DataAddress #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
enhancement
ndr-brt
requested review from
bscholtes1A,
jimmarino,
ronjaquensel and
juliapampus
as code owners
ndr-brt
force-pushed
the
3841-dspace-dataaddress
branch
2 times, most recently
from
d663591 to
7c439b0
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3975 +/- ##
==========================================
+ Coverage 71.74% 73.38% +1.64%
==========================================
Files 919 961 +42
Lines 18457 19397 +940
Branches 1037 1092 +55
==========================================
+ Hits 13242 14235 +993
+ Misses 4756 4699 -57
- Partials 459 463 +4 ☔ View full report in Codecov by Sentry. |
ndr-brt
force-pushed
the
3841-dspace-dataaddress
branch
2 times, most recently
from
bf6f7e9 to
5cda4b4
Compare
ndr-brt
force-pushed
the
3841-dspace-dataaddress
branch
from
5cda4b4 to
323fd32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Use
dspace:DataAddressformat on DSP wire.BREAKING CHANGE an EDC connector after this PR will be compliant with DSP version 2024/1 but it won't be interoperable with older EDC connector versions.
Why it does that
dsp compliance
Further notes
transform-dspacethat is meant to contain thedspacerelated transformers. A subsequent refactoring is needed to sort transformers a little (issue will come up)Linked Issue(s)
Closes #3841
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.