Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EDR cache API #3983

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Mar 8, 2024

What this PR changes/adds

EDR API for query/fetching/deleting cached EDR on consumer side

Why it does that

data plane signaling, user experience

Further notes

Currently it's plugged under the management-api context as required by the issue #3974, we might want to consider
to separate the APIs in it's own context or make it configurable, since it could make sense to deploy this in the dataplane internal API also.

Linked Issue(s)

Closes #3974

@wolf4ood wolf4ood force-pushed the feat/3974_edr_cache_api branch from a92e50a to fb792e8 Compare March 8, 2024 15:15
@wolf4ood wolf4ood self-assigned this Mar 8, 2024
@wolf4ood wolf4ood added enhancement New feature or request api Feature related to the (REST) api labels Mar 8, 2024
@wolf4ood wolf4ood marked this pull request as ready for review March 8, 2024 15:45
@wolf4ood wolf4ood requested a review from ndr-brt March 8, 2024 15:49
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.56%. Comparing base (7f20ba5) to head (b80c14e).
Report is 453 commits behind head on main.

Files with missing lines Patch % Lines
...r/api/management/edr/v1/EdrCacheApiController.java 92.85% 1 Missing and 1 partial ⚠️
...ector/api/management/edr/EdrCacheApiExtension.java 85.71% 1 Missing ⚠️
...c/connector/api/management/edr/v1/EdrCacheApi.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3983      +/-   ##
==========================================
+ Coverage   71.74%   73.56%   +1.81%     
==========================================
  Files         919      972      +53     
  Lines       18457    19581    +1124     
  Branches     1037     1099      +62     
==========================================
+ Hits        13242    14404    +1162     
+ Misses       4756     4709      -47     
- Partials      459      468       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/3974_edr_cache_api branch from b921d4c to ab742a2 Compare March 11, 2024 09:24
@wolf4ood wolf4ood force-pushed the feat/3974_edr_cache_api branch from ab742a2 to b80c14e Compare March 11, 2024 09:41
@wolf4ood wolf4ood merged commit 99ecae9 into eclipse-edc:main Mar 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPS: EDC cache management API
4 participants