Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce boot-lib and http-lib modules #4030

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

jimmarino
Copy link
Contributor

As described in #4028 and #4029 this PR introduces the boot-lib and http-lib modules. Specifically:

  • It breaks the cyclic dependency between connector-core and Junit by moving EdcHttpClientImpl into the http-lib modules and getFreePorts() to a utility method in the core util module.
  • Moves the InMemoryVault implementation to the boot-lib module so that it can be referenced without exposing visibility to core services
  • Starts to clean up dependencies on connector-core. These will be refined in subsequent PRs.

Linked Issue(s)

Closes #4029

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@jimmarino jimmarino added the refactoring Cleaning up code and dependencies label Mar 21, 2024
@jimmarino jimmarino requested a review from wolf4ood March 21, 2024 11:23
@jimmarino jimmarino self-assigned this Mar 21, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.28%. Comparing base (7f20ba5) to head (0bf4621).
Report is 159 commits behind head on main.

Files Patch % Lines
...l/src/main/java/org/eclipse/edc/util/io/Ports.java 83.33% 1 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4030      +/-   ##
============================================
- Coverage     71.74%   62.28%   -9.47%     
- Complexity        0     4240    +4240     
============================================
  Files           919      989      +70     
  Lines         18457    20053    +1596     
  Branches       1037     1126      +89     
============================================
- Hits          13242    12490     -752     
- Misses         4756     7136    +2380     
+ Partials        459      427      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@jimmarino jimmarino merged commit 7493208 into eclipse-edc:main Mar 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce boot-lib and http-lib modules
3 participants