feat: implement before event for asset policy contract definition in their listeners #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in their corresponding listener classes
… in their corresponding listener classes
suh-rao
changed the title
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4035 +/- ##
===========================================
- Coverage 71.74% 19.09% -52.65%
===========================================
Files 919 994 +75
Lines 18457 20120 +1663
Branches 1037 1126 +89
===========================================
- Hits 13242 3842 -9400
- Misses 4756 16165 +11409
+ Partials 459 113 -346 ☔ View full report in Codecov by Sentry. |
suh-rao
changed the title
suh-rao
changed the title
|
This pull request is stale because it has been open for 7 days with no activity. |
|
This pull request was closed because it has been inactive for 7 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
With this change now beforeCreate and beforeUpdate event will be triggered for asset, policy, contract definition entities.
This event will be triggereed before entities gets saved to database.
Why it does that
Currently we have only event which gets triggered after CUD operation successfully performed on databse.
In some scenario it might be necessary to make changes before create or update operation performed on database.
Further notes
In asset, policy and contract definition Listener classes add beforeUpdate and beforeCreate event.
This will triggerred in corresponding service implementation class method create, update before performing DB operation
Linked Issue(s)
Closes #4006
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.