chore: extract base controllers for all DSP apis #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/4665_extract_dsp_http_libs
branch
from
6f65b0b to
ad1684d
Compare
wolf4ood
added
enhancement
wolf4ood
force-pushed
the
feat/4665_extract_dsp_http_libs
branch
3 times, most recently
from
7cf61c1 to
2ba5dd4
Compare
wolf4ood
force-pushed
the
feat/4665_extract_dsp_http_libs
branch
from
2ba5dd4 to
f2aebc4
Compare
wolf4ood
requested review from
ronjaquensel,
juliapampus and
ndr-brt
as code owners
paullatzelsperger
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Extract the base logic for dsp controllers:
into
dsp-*-http-api-libreusabe across different dsp version implementationsWhy it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4665
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.