chore(DataPlanePublicAPI): Error message handling #4678
Conversation
Changed error handling method to be returned directly as list, instead of being concatenated first and then wrapped to the list
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contributors manual, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
Minor adjustment in returned value of should_returnInternalServerError_if_transferFails test, adding test case for should_returnListOfErrorsAsAResponse_if_anythingFails
| .then() | ||
| .statusCode(Response.Status.INTERNAL_SERVER_ERROR.getStatusCode()) | ||
| .contentType(JSON) | ||
| .body("errors", is(List.class)); |
There was a problem hiding this comment.
This test does not properly verify the change. Compare it to how the original test verifies the error messages.
Fix in unit test matcher
| .then() | ||
| .statusCode(Response.Status.INTERNAL_SERVER_ERROR.getStatusCode()) | ||
| .contentType(JSON) | ||
| .body("errors", isA(List.class)); |
There was a problem hiding this comment.
This still does not verify multiple messages are included. The test is only verifying a list type, which has not changed.
Added detailed assertions to an unit test should_returnListOfErrorsAsAResponse_if_anythingFails
|
|
||
| baseRequest() | ||
| var jsonPath = baseRequest() |
There was a problem hiding this comment.
Why is this called jsonPath?
|
In the future, please:
Thx |
Code cleanup, renamed variable
|
This pull request is stale because it has been open for 7 days with no activity. |
|
This pull request was closed because it has been inactive for 7 days since being marked as stale. |
…sponse_refactor' into DataplaneControllerAPIV2_errorResponse_refactor
…sponse_refactor' into DataplaneControllerAPIV2_errorResponse_refactor
…sponse_refactor' into DataplaneControllerAPIV2_errorResponse_refactor
What this PR changes/adds
Changed error handling method to be returned directly as list, instead of being concatenated first and then wrapped to the list
Why it does that
In order to make an error response being more readable
Further notes
N/A
Linked Issue(s)
Closes #4670