feat: connector client: switch PolicyService #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the current state on creating a new Policy the values are not used given in the Dialog. Also i have the question about the assignee and assigner of a policy. Does the still exist? Because i don't see this fields in the management-Api Documentation. Or i just did not see it? @ndr-brt |
|
@janpmeyer they are part of the ODRL model, but they are not used by the EDC, so they can be avoided |
|
@ndr-brt fixed now the id of an policyDefiniton and also the permission field of the policy. But the fields prohibition and obligation are not working yet |
|
With the new EDC-Connector-Client Beta-6 obligations and prohibitions are also working. |
ndr-brt
approved these changes
Sep 14, 2023
.../components/contract-definition-editor-dialog/contract-definition-editor-dialog.component.ts
Outdated
Show resolved
Hide resolved
farhin23
pushed a commit
to FraunhoferISST/edc-dashboard
that referenced
this pull request
Mar 5, 2024
* feat: switch PolicyDefinition to connector client (eclipse-edc#38) * feat: fix id and permission on creating new Policy (eclipse-edc#58) * feat: use get functions for obligations and prohibition in View (eclipse-edc#58) * feat: remove unnecessary import (eclipse-edc#58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Use EDC-connector-client for `ContractDefinition
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #58 and Closese #65