Signature alg fix #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't appear to be any way for the setSignatureAlgorithm(...) in com.sun.xml.ws.security.trust.impl.client.DefaultSTSIssuedTokenConfiguration to actually set/override the signature algorithm for STS requests, instead it's always reset to null and thus defaults to SHA1.
This patch allows the setting to pass through to the context and sets the signature algorithm in the algorithm suite. I'm unclear on how the internals of the API are intended to set/pass through this value, if this is not correct then I'm happy to discuss.
There appears to also be an issue with WSDL set signature algorithms not addressed here, they don't seem to actually show up in requests or while debugging the request creation (Please refer to #57)