#4262 - don't restore rowIndex in UIData#invokeOnComponent, if it …

[fcaputo]

Don't restore rowIndex in UIData#invokeOnComponent, if it was not modified

setRowIndex is called in finally, even if the rowIndex was not modified
by invokeOnComponent. This leads to unexpected method calls. This commit
reduces the scope of the try catch finally.

Fixes #4262

[arjantijms]

Hi Frank, in order for us to merge this you have to pass the Eclipse IP validation.

To do so, it's necessary to create an Eclipse account and accept the ECA. Then make sure you link your Eclipse account to the same account used for the commit. Finally, you have to sign off the commit (see https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for)

Then, you have to redo the PR or do a new commit unfortunately, as that's needed to kick the IP Validation check to test again.

Also, not sure why you referenced bug 4262: https://bugs.eclipse.org/bugs/show_bug.cgi?id=4262 it seems to be totally unrelated to Mojarra.

[manorrock]

Hi Frank, The PR is also missing a test. Thanks! Kind regards, Manfred Riem

…

On Oct 28, 2018, at 9:07 AM, Arjan Tijms ***@***.***> wrote: Hi Frank, in order for us to merge this you have to pass the Eclipse IP validation. To do so, it's necessary to create an Eclipse account and accept the ECA. Then make sure you link your Eclipse account to the same account used for the commit. Finally, you have to sign off the commit (see https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for) Then, you have to redo the PR or do a new commit unfortunately, as that's needed to kick the IP Validation check to test again. Also, not sure why you referenced bug 4262: https://bugs.eclipse.org/bugs/show_bug.cgi?id=4262 it seems to be totally unrelated to Mojarra. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[pzygielo]

@arjantijms: I think PR is about #4262, but eclipsewebmaster somehow linked here different one.

[arjantijms]

@pzygielo Ah I see, my mistake as well, since I did look for a Github issue but accidentally looked for 4622 :O

[fcaputo]

Hi Arjan, I linked my eclipse account to the github account now. Regarding the sign off, I thought, that I was listed as an initial committer as written here: https://projects.eclipse.org/proposals/eclipse-mojarra This would make the sign off unnecessary, right? But looking at my eclipse account, I am not listed as a committer. Best regards, Frank

…

Am 28.10.2018 um 16:07 schrieb Arjan Tijms ***@***.***>: Hi Frank, in order for us to merge this you have to pass the Eclipse IP validation. To do so, it's necessary to create an Eclipse account and accept the ECA. Then make sure you link your Eclipse account to the same account used for the commit. Finally, you have to sign off the commit (see https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for <https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for>) Then, you have to redo the PR or do a new commit unfortunately, as that's needed to kick the IP Validation check to test again. Also, not sure why you referenced bug 4262: https://bugs.eclipse.org/bugs/show_bug.cgi?id=4262 <https://bugs.eclipse.org/bugs/show_bug.cgi?id=4262> it seems to be totally unrelated to Mojarra. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4506 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABE37AuB4niJgnmnu9ghMG82anZStPYKks5upcg4gaJpZM4X97hr>.

[pzygielo]

@fcaputo: as per my understanding The_Commit_Record is about every single commit.

[fcaputo]

Hi, I created a new pull request, which meets all requirements. Best regards, Frank

…

Am 28.10.2018 um 16:25 schrieb manorrock ***@***.***>: Hi Frank, The PR is also missing a test. Thanks! Kind regards, Manfred Riem > On Oct 28, 2018, at 9:07 AM, Arjan Tijms ***@***.***> wrote: > > Hi Frank, in order for us to merge this you have to pass the Eclipse IP validation. > > To do so, it's necessary to create an Eclipse account and accept the ECA. Then make sure you link your Eclipse account to the same account used for the commit. Finally, you have to sign off the commit (see https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for) > > Then, you have to redo the PR or do a new commit unfortunately, as that's needed to kick the IP Validation check to test again. > > Also, not sure why you referenced bug 4262: https://bugs.eclipse.org/bugs/show_bug.cgi?id=4262 it seems to be totally unrelated to Mojarra. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4506 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABE37Dh9aIJJekw2vgy8q6peAPynYZQ-ks5upcyAgaJpZM4X97hr>.

[pzygielo]

as per my understanding The_Commit_Record is about every single commit.

@fcaputo Apparently I was wrong about every single commit part, as explained to me by Ben.