Generics + Some code optimization (at least for readability)

[pizzi80]

• Generics
• StringBuffer -> StringBuilder
• Minor modernizations

I made half of the TCK tests with no errors

Also I'm testing this release in production on a side (but complete) crud project
and everything works as expected

I have problem to execute tests that uses selenium because chrome version is now 114 and not 86...
I tried to change the release of selenium inside /tck/util/pom.xml to the latest but the error remains...

[BalusC]

Great but can you please:

• revert all changes in public API methods (whereby you basically change compile time method signatures etc by e.g. introducing generics, this is not allowed without spec change).
• revert all changes related to generics in Converter and Validator (they were raw for backwards compatibility with those written for JSF 1.x and I'm not sure if TCK covers all those edge cases as well (cc: @arjantijms )).

And for the next time it would be better if you can split related/self-containing/isolated changes into separate PRs. E.g. one PR for all StringBuffer->StringBuilder changes, another PR for all non-interface declarations, another PR for enhanced loops, etc. It would make the PRs less big and easier to review/manage and the good parts can be quicker merged.

[pizzi80]

When will be possible to change the api?

Jsf 2.3 has Generics in converters and validators

Jsf 2.2 is in EOL since maybe 2019

Generics is Java 5 technology,
Jakarta EE11 (few months) will be Java 21+...

[BalusC]

When will be possible to change the api?

Next Faces version.

Jsf 2.3 has Generics in converters and validators
Jsf 2.2 is in EOL since maybe 2019
Generics is Java 5 technology,
Jakarta EE11 (few months) will be Java 21+...

True. We can change it for next Faces version but not for current version. You're basically breaking the API contract. You can basically only do that for a next major version. I.e. Faces 5.0.