Add UUIDConverter #5243
Merged
Add UUIDConverter #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UUIDConverter
Register UUIDConverter
Add message translations for de/en/es/pt
|
Add Chinese translation #5244 |
Chinese tran for UUID Converter
Added French translation, unverified, it was a best guess based on existing NumberConverter.PERCENT translation.
|
when will be merged? |
When one reviewer has approved it. |
pzygielo
reviewed
Jun 25, 2023
| try { | ||
| return value.toString(); | ||
| } catch (Exception e) { | ||
| throw new ConverterException(MessageFactory.getMessage(context, STRING_ID, value, MessageFactory.getLabel(context, component)), e); |
There was a problem hiding this comment.
Just out of curiosity - assuming value.toString() throws - what is expected to happen with the message [for ConverterException] preparation? I suppose another value.toString call to be made...
There was a problem hiding this comment.
Sharp. This logic was just extracted as a template from existing faces converters. And I believe the majority just wanted to catch a potential ClassCastException, but this is for the UUIDConverter not necessary because it's the first standard converter to be parameterized from the beginning on.
arjantijms
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jakartaee/faces#1819