"final" on effective final fields #5250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Java style array declaration instead of C-style Signed-off-by: pizzi80 <[email protected]>
BalusC
reviewed
Jun 24, 2023
| private FacesEvent event = null; | ||
| private int rowIndex = -1; | ||
| private final FacesEvent event; | ||
| private final int rowIndex; |
There was a problem hiding this comment.
Why was -1 default removed? Seems a breaking change.
There was a problem hiding this comment.
Nevermind. The PR didn't show that it was in a nested class WrapperEvent extends FacesEvent. Approved.
BalusC
reviewed
Jun 24, 2023
BalusC
reviewed
Jun 24, 2023
Signed-off-by: pizzi80 <[email protected]>
BalusC
reviewed
Nov 3, 2024
| private static ConcurrentHashMap threadInitContext = new ConcurrentHashMap(2); | ||
| private static ConcurrentHashMap initContextServletContext = new ConcurrentHashMap(2); | ||
| private static final ConcurrentHashMap<Thread,FacesContext> threadInitContext = new ConcurrentHashMap<>(2); | ||
| private static final ConcurrentHashMap<Thread,InitFacesContext> initContextServletContext = new ConcurrentHashMap<>(2); |
There was a problem hiding this comment.
FYI: this caused a major problem during 4.1.1/4.1.2 release.
Please never import Impl specific classes into API classes :)
It's already fixed. Just a heads up for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalon effective final fields