Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LRUCache + ELUtils #5266

Merged
merged 5 commits into from
Jul 1, 2023
Merged

LRUCache + ELUtils #5266

merged 5 commits into from
Jul 1, 2023

Conversation

pizzi80
Copy link
Contributor

@pizzi80 pizzi80 commented Jun 22, 2023 •
edited
Loading

  • LRUCache implementation adapted to the Util codebase of Faces
  • ELUtils use the new LRUCache instead of a custom local implementation

The LRUCache can also be used in other part of the code that now use
a Collection.synchronizeMap over the LRUMap

@pizzi80
+ LRUCache
4b8c15b 
+ ELUtils use the new LRUCache instead of a custom local implementation

Signed-off-by: pizzi80 <[email protected]>
@pizzi80
+ LRUCache
68c337d 
+ ELUtils use the new LRUCache instead of a custom local implementation

Signed-off-by: pizzi80 <[email protected]>
@pizzi80
+ + LRUCache
3090c8f 
+ ELUtils use the new LRUCache instead of a custom local implementation

Signed-off-by: pizzi80 <[email protected]>
@pizzi80
+ + LRUCache
a4894df 
+ ELUtils use the new LRUCache instead of a custom local implementation

Signed-off-by: pizzi80 <[email protected]>
@BalusC
Copy link
Contributor

BalusC commented Jun 24, 2023 •
edited
Loading

Looks great for the remainder :)

@pizzi80
+ fixed blanks lines
beedcf3 
+ improved and unified Factory and Function with Cache

Signed-off-by: pizzi80 <[email protected]>
@pizzi80
Copy link
Contributor Author

pizzi80 commented Jun 25, 2023

I've further improved and unified with the Cache.Factory inside util.Cache

what do you think?

@BalusC
Copy link
Contributor

BalusC commented Jul 1, 2023

This is a great improvement.

@BalusC BalusC merged commit c1d183a into eclipse-ee4j:master Jul 1, 2023
@arjantijms arjantijms added the 5.0 label Jul 6, 2023
@pizzi80 pizzi80 deleted the 4.1.0_LRU_cache_v2 branch July 12, 2023 13:34
@BalusC BalusC added 4.1 and removed 5.0 labels Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalusC BalusC BalusC left review comments

Assignees
No one assigned
Labels
4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pizzi80 @BalusC @arjantijms