Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and deprecated @PostConstructCustomScopeEvent and @PreDestroyCustomScopeEvent #5292

Closed
wants to merge 1 commit into from

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Jul 29, 2023

jakartaee/faces#1830

cc: @tandraschko (note: for 5.0)

Remove unused and deprecated @PostConstructCustomScopeEvent and
@PreDestroyCustomScopeEvent
@BalusC BalusC requested a review from arjantijms July 29, 2023 12:35
@pnicolucci
Copy link
Contributor

We need to hold off on this for 5.0 unless an exception to the process is granted. These classes were deprecated in 4.1 which is not part of any Jakarta Platform (EE10/EE11 etc). See the email thread: https://www.eclipse.org/lists/faces-dev/msg00321.html

@BalusC
Copy link
Contributor Author

BalusC commented Aug 3, 2023

It should be noted that these classes have no effect/usage at all because they are since 4.0 not anymore invoked because the associated @CustomScoped scope implementation has been removed in 4.0. In other words, removal would only have compilation errors as consequence no runtime errors.

@BalusC
Copy link
Contributor Author

BalusC commented Sep 2, 2023

Declined. We can apparently not deprecate things in a minor version.

@BalusC BalusC closed this Sep 2, 2023
@BalusC BalusC deleted the faces_issue_1830 branch September 7, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants