Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML escaping when writing attributes #5465

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Fix XML escaping when writing attributes #5465

merged 2 commits into from
Aug 3, 2024

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Jul 26, 2024

@BalusC BalusC requested review from arjantijms and mnriem July 26, 2024 13:05
Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any specific tests testing this change?

@BalusC
Copy link
Contributor Author

BalusC commented Jul 28, 2024

Do we have any specific tests testing this change?

Integration test isn't anymore possible in Mojarra project since the split of TCK. All the config is ripped from the Mojarra project. Everything has been moved to Faces TCK project where adding new tests for the current Faces version isn't anymore possible as per the unfortunate rules of the TCK. You can in TCK only add tests for the next Faces version but any tests which would benefit current Faces version as well thus won't be launched. TCK is therefore useless for issues encountered in the current Faces version. Unit test is however possible for this specific use case and we can fortunately still put them in Mojarra project. I'll look at it.

In long term I really wish to be able to run integration tests from Mojarra project again. We can always simply migrate these to the TCK when a new major/minor version is to be released.

@BalusC
Copy link
Contributor Author

BalusC commented Jul 28, 2024

Do we have any specific tests testing this change?

I added an unit test.

But I really wish being able to test this with an integration test because the unit test itself still doesn't guarantee that the very <f:ajax> tag (regardless of the implementation) is using the desired logic.

@BalusC BalusC merged commit bf8ec2d into 4.0 Aug 3, 2024
3 checks passed
@BalusC BalusC deleted the mojarra_issue_5464 branch August 3, 2024 13:38
@BalusC BalusC added this to the 4.0.8 milestone Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants