Support new FacesMessage.Severity.SUCCESS in h:message/h:messages #5490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rather see Severity.NONE instead of SUCCESS. |
|
That's not what was requested by community jakartaee/faces#1592. |
|
I realize that, but it seems an odd fit. Or asking a nice LLM to explain message severity and "SUCCES" to me: 'In the context of message severity, “SUCCESS” is generally not considered a severity level. Severity levels typically indicate the urgency or criticality of an issue, ranging from emergency situations to debug information. “SUCCESS” is more of a status or outcome, indicating that an operation or process completed as intended without errors' |
|
Please continue in jakartaee/faces#1592 |
BalusC
deleted the
mojarra_issue_5489_support_FacesMessage.Severity.SUCCESS
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5489
Associated PR in Faces side: jakartaee/faces#1964