Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package-info.class files inside org.eclipse.parsson:jakarta.json are compiled with the wrong Java version #73 #74

Merged
merged 1 commit into from
Apr 21, 2023
Merged

package-info.class files inside org.eclipse.parsson:jakarta.json are compiled with the wrong Java version #73 #74

merged 1 commit into from
Apr 21, 2023

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Nov 24, 2022 •
edited
Loading

Relates to #73

To verify the fix:

$ mvn clean install
$ javap -verbose -classpath bundles/jakarta.json/target/jakarta.json-1.1.2-SNAPSHOT.jar jakarta.json.package-info | grep version
  minor version: 0
  major version: 52

Javadoc of packages are still there, you can verify it opening bundles/jakarta.json/target/site/apidocs/jakarta.json/jakarta/json/package-summary.html

@jbescos
package-info.class files inside org.eclipse.parsson:jakarta.json are …
ad1c964 
…compiled with the wrong Java version eclipse-ee4j#73

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos jbescos mentioned this pull request Nov 24, 2022
Merged
lukasj
lukasj approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 7c9a82d into eclipse-ee4j:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbescos @lukasj