-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all positive cases for None and WildFly runtimes #307
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address all review feedback.
Is this once again ready for review? When it is, please take status out of draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order by SE version (starting with the lowest), runtime/none (alphabetic, starting with none), EE version (starting with the lowest), profile (full, web, core), and Docker (no, yes).
So like this:
- Run Archetype for EE 8 Web Profile, SE 8, Payara
- Run Archetype for EE 8 Web Profile, SE 8, Payara, with Docker
Where Docker is really not supported (a warning is generated by the Archetype), we should not treat that as a "positive case". That's a negative case we need to test for later.
Please order your part and the file overall - including existing cases. Confusing to read and evaluate otherwise for me.
.github/workflows/nightly.yml
Outdated
@@ -30,82 +30,437 @@ jobs: | |||
run: | | |||
mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -Dprofile=full -DjavaVersion=8 -DoutputDirectory=app -Dgoals="clean package" | |||
rm -rf app | |||
|
|||
|
|||
- name: Run Archetype for EE 8 Full Profile, SE 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a duplicate of the one above. Please delete one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-read and understand the previous review comments. All cases where Docker is not a valid option should be removed as it is not really a "positive" case. These will be added later as negative cases where we explicitly check that a warning was generated and there is no Dockerfile.
Is this ready for another review? |
I apologize for my oversight. I initially thought I was generating only the positive cases based on the UI, but upon further inspection, I realized this was not the case. Thank you for pointing this out. As for duplicate cases, I kept the original ones. I have also changed the naming scheme to match the original cases. However, for the following duplicate case I kept the new one. Original
New
|
NP. That’s the point of the review. Hopefully I can take a look during the work week. |
Looks great! Thanks for working through this. |
No description provided.