Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative cases for TomEE #323

Closed
wants to merge 4 commits into from
Closed

Negative cases for TomEE #323

wants to merge 4 commits into from

Conversation

jannahsherif
Copy link
Contributor

No description provided.

@eclipse-starter-bot
Copy link

Can one of the admins verify this patch?

@m-reza-rahman m-reza-rahman changed the title Negative cases for tomee Negative cases for TomEE Jul 25, 2024
@m-reza-rahman
Copy link
Contributor

Please resolve conflicts.

@jannahsherif
Copy link
Contributor Author

I just resolved them. I did SE 8 just to make sure i am going in the right direction

Copy link
Contributor

@m-reza-rahman m-reza-rahman Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the TomEE validation:

, I see that the lack of EE 10 support negative test case ( ), amongst possibly others, is missing. Please add that/those.

mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=9 -DjavaVersion=8 -Druntime=tomee -DoutputDirectory=app/tomee -Dgoals="clean package" | tee mvn_output.txt

MAVEN_EXIT_CODE=${PIPESTATUS[0]}
ERROR_MESSAGE="TomEE requires Web Profile and Jakarta EE 8 or 9.1."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error messages you need to check for will be from the Archetype, not the UI. Please look here: https://github.com/eclipse-ee4j/starter/blob/master/archetype/src/main/resources/META-INF/archetype-post-generate.groovy.

mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=9.1 -DjavaVersion=8 -Druntime=tomee -DoutputDirectory=app/tomee -Dgoals="clean package" | tee mvn_output.txt

MAVEN_EXIT_CODE=${PIPESTATUS[0]}
ERROR_MESSAGE="TomEE requires Web Profile and Jakarta EE 8 or 9.1."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error messages you need to check for will be from the Archetype, not the UI. Please look here: https://github.com/eclipse-ee4j/starter/blob/master/archetype/src/main/resources/META-INF/archetype-post-generate.groovy.

mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=9.1 -Dprofile=web -DjavaVersion=8 -Druntime=tomee -DoutputDirectory=app/tomee -Dgoals="clean package" | tee mvn_output.txt

MAVEN_EXIT_CODE=${PIPESTATUS[0]}
ERROR_MESSAGE="TomEE requires Web Profile and Jakarta EE 8 or 9.1."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error messages you need to check for will be from the Archetype, not the UI. Please look here: https://github.com/eclipse-ee4j/starter/blob/master/archetype/src/main/resources/META-INF/archetype-post-generate.groovy.

mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.3.0-SNAPSHOT -DjakartaVersion=8 -DjavaVersion=8 -Druntime=tomee -DoutputDirectory=app/tomee -Dgoals="clean package" | tee mvn_output.txt

MAVEN_EXIT_CODE=${PIPESTATUS[0]}
ERROR_MESSAGE="TomEE requires Web Profile and Jakarta EE 8 or 9.1."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error messages you need to check for will be from the Archetype, not the UI. Please look here: https://github.com/eclipse-ee4j/starter/blob/master/archetype/src/main/resources/META-INF/archetype-post-generate.groovy.

Copy link
Contributor

@m-reza-rahman m-reza-rahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error messages and use cases are not correct. They need to correspond to the Archetype validation. I suggest getting guidance from Tasnim and/or Elzeni.

@m-reza-rahman m-reza-rahman marked this pull request as draft July 26, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants