rectpacking: Fix micro layout for rectpacking including content alignment and label placement. #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was only done after because whitespace elimination might change node sizes. However, if the node size cannot fit the label, we need to do this before the layout too.
Translate inner content based on the real width and the width of the parent.
soerendomroes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was only done after because whitespace elimination might change node sizes. However, if the node size cannot fit the label, we need to do this before the layout too.
I suggest to maybe take a look at #989 and see whether this has the same reason. If both are fixed, I propose an elkjs only release for this fix.
Also fixes #996