Move Equinox Launcher to Java-17 #829

HannesWell · 2025-02-01T15:46:00Z

Move Equinox Launcher to Java-17 as suggested in #782 (comment).
And leverage the new language features to modernize the code a bit.

eclipse-equinox-bot · 2025-02-01T15:49:32Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.launcher.cocoa.macosx.aarch64/META-INF/MANIFEST.MF
bundles/org.eclipse.equinox.launcher.cocoa.macosx.x86_64/META-INF/MANIFEST.MF
bundles/org.eclipse.equinox.launcher.win32.win32.aarch64/META-INF/MANIFEST.MF
bundles/org.eclipse.equinox.launcher.win32.win32.x86_64/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From fcc1e3415197487aca205ec22c4a9771c57e9ea6 Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <[email protected]>
Date: Sat, 1 Feb 2025 15:49:10 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.equinox.launcher.cocoa.macosx.aarch64/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.launcher.cocoa.macosx.aarch64/META-INF/MANIFEST.MF
index 472ef2036..e49a4d69e 100644
--- a/bundles/org.eclipse.equinox.launcher.cocoa.macosx.aarch64/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.launcher.cocoa.macosx.aarch64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.equinox.launcher.cocoa.macosx.aarch64;singleton:=true
-Bundle-Version: 1.2.1100.qualifier
+Bundle-Version: 1.2.1200.qualifier
 Fragment-Host: org.eclipse.equinox.launcher;bundle-version="[1.7.0,1.8.0)"
 Eclipse-PlatformFilter: (& (osgi.ws=cocoa) (osgi.os=macosx) (osgi.arch=aarch64) )
 Bundle-Localization: launcher.cocoa.macosx.aarch64
diff --git a/bundles/org.eclipse.equinox.launcher.cocoa.macosx.x86_64/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.launcher.cocoa.macosx.x86_64/META-INF/MANIFEST.MF
index d03494cff..d8a8b4551 100644
--- a/bundles/org.eclipse.equinox.launcher.cocoa.macosx.x86_64/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.launcher.cocoa.macosx.x86_64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.equinox.launcher.cocoa.macosx.x86_64;singleton:=true
-Bundle-Version: 1.2.1100.qualifier
+Bundle-Version: 1.2.1200.qualifier
 Fragment-Host: org.eclipse.equinox.launcher;bundle-version="[1.7.0,1.8.0)"
 Eclipse-PlatformFilter: (& (osgi.ws=cocoa) (osgi.os=macosx) (osgi.arch=x86_64) )
 Bundle-Localization: launcher.cocoa.macosx.x86_64
diff --git a/bundles/org.eclipse.equinox.launcher.win32.win32.aarch64/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.launcher.win32.win32.aarch64/META-INF/MANIFEST.MF
index 65607fc21..40d63f586 100644
--- a/bundles/org.eclipse.equinox.launcher.win32.win32.aarch64/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.launcher.win32.win32.aarch64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.equinox.launcher.win32.win32.aarch64;singleton:=true
-Bundle-Version: 1.2.1100.qualifier
+Bundle-Version: 1.2.1200.qualifier
 Fragment-Host: org.eclipse.equinox.launcher;bundle-version="[1.7.0,1.8.0)"
 Eclipse-PlatformFilter: (& (osgi.ws=win32) (osgi.os=win32) (osgi.arch=aarch64))
 Bundle-Localization: launcher.win32.win32.aarch64
diff --git a/bundles/org.eclipse.equinox.launcher.win32.win32.x86_64/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.launcher.win32.win32.x86_64/META-INF/MANIFEST.MF
index 14642bb39..3285f78fb 100644
--- a/bundles/org.eclipse.equinox.launcher.win32.win32.x86_64/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.launcher.win32.win32.x86_64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.equinox.launcher.win32.win32.x86_64;singleton:=true
-Bundle-Version: 1.2.1100.qualifier
+Bundle-Version: 1.2.1200.qualifier
 Fragment-Host: org.eclipse.equinox.launcher;bundle-version="[1.7.0,1.8.0)"
 Eclipse-PlatformFilter: (& (osgi.ws=win32) (osgi.os=win32) (osgi.arch=x86_64))
 Bundle-Localization: launcher.win32.win32.x86_64
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

vogella · 2025-02-01T15:53:31Z

Thanks for this work @HannesWell

What is the reason not to jump directly to Java 21? I think @tjwatson indicated that that would also be fine

laeubi · 2025-02-01T16:05:59Z

I can see that org.eclipse.equinox.launcher is used in some places in Tycho to support running eclipse applications, so one should make sure that it is still possible to launch older eclipse installations.

What is the reason not to jump directly to Java 21? I think @tjwatson indicated that that would also be fine

Large parts of Eclipse/Equinox can still run on Java 17, so what would be the immediate benefits here to break those?

laeubi

I would wait until next release for this change, at least warnings/deprecation should be fixed and not suppressed.

laeubi · 2025-02-01T16:07:17Z

bundles/org.eclipse.equinox.launcher/src/org/eclipse/equinox/launcher/Main.java

@@ -2609,6 +2592,7 @@ private void setMultiValueProperty(String property, String[] values) {
 	 * nobody will actually call them (unless they casted the policy to EclipsePolicy and
 	 * called our methods)
 	 */
+	@SuppressWarnings({"removal", "deprecation"})


If we have new warnings due to updated java version it should not be suppressed but fixed along side with the java update.

The new warning is because the Policy class is deprecated along with the SecurityManager. I'd more than happy to just remove it, but I assume that's not yet desired, is it?

I do think there are scenarios (ant?) that still optionally set a security manager when using Java 21 so I don't think we can really remove this policy stuff just yet.

Ant isn't such scenario as it just sets the security-manager if the running JVM is blow 18:

Consider VM-configuration when determining if SecurityManager may be set apache/ant#216

But there could be other scenarios that require it. So I assume that part should stay as long as the security-manager code is removed.
Btw. is there a plan for how to deal with that? Or is the plan to keep it as long as it works/compiles on all released Java versions?

Btw. is there a plan for how to deal with that? Or is the plan to keep it as long as it works/compiles on all released Java versions?

It depends on the component. For the most part, there should be little references to the actual SecurityManager or Policy in our code itself. The Framework itself has many places it is referenced, but they should be able to be contained into an internal utility that fails gracefully on a future JVM where the actual classes are removed.

The biggest issue is code all over the place that have references to java.security.AccessController.doPrivileged(PrivilegedAction<String>, AccessControlContext) and hundreds of implementations of java.security.PrivilegedAction<T> or java.security.PrivilegedExceptionAction<T>

My suspicion is that these APIs will be around much longer than the SecurityManager and Policy classes, but will become no-op methods when calling doPrivileged. I don't see them being able to truly remove the doPrivileged APIs until all the long term support of Java 8 finally end.

github-actions · 2025-02-01T16:14:35Z

Test Results

669 files ±0 669 suites ±0 1h 13m 23s ⏱️ -10s
2 223 tests ±0 2 176 ✅ ±0 47 💤 ±0 0 ❌ ±0
6 813 runs ±0 6 670 ✅ ±0 143 💤 ±0 0 ❌ ±0

Results for commit 652ea3f. ± Comparison against base commit e35221a.

HannesWell · 2025-02-05T00:17:34Z

I would wait until next release for this change, at least warnings/deprecation should be fixed and not suppressed.

I'm fine postponing the entire change to the next dev-cycle, I don't think it's urgent. Maybe I'll add some follow-up changes in separate commits in the meantime, but they can later be moved to separate PRs as well.

HannesWell added 2 commits February 1, 2025 15:56

Move Equinox Launcher to Java-17

9f3f011

Minor modernizations in equinox launcher Main

52c599e

HannesWell requested a review from tjwatson February 1, 2025 15:46

Version bump(s) for 4.35 stream

652ea3f

laeubi requested changes Feb 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Equinox Launcher to Java-17 #829

Move Equinox Launcher to Java-17 #829

HannesWell commented Feb 1, 2025

eclipse-equinox-bot commented Feb 1, 2025

vogella commented Feb 1, 2025

laeubi commented Feb 1, 2025

laeubi left a comment

laeubi Feb 1, 2025

HannesWell Feb 1, 2025

laeubi Feb 1, 2025

tjwatson Feb 3, 2025

HannesWell Feb 5, 2025

tjwatson Feb 5, 2025

github-actions bot commented Feb 1, 2025

HannesWell commented Feb 5, 2025

Move Equinox Launcher to Java-17 #829

Are you sure you want to change the base?

Move Equinox Launcher to Java-17 #829

Conversation

HannesWell commented Feb 1, 2025

eclipse-equinox-bot commented Feb 1, 2025

vogella commented Feb 1, 2025

laeubi commented Feb 1, 2025

laeubi left a comment

Choose a reason for hiding this comment

laeubi Feb 1, 2025

Choose a reason for hiding this comment

HannesWell Feb 1, 2025

Choose a reason for hiding this comment

laeubi Feb 1, 2025

Choose a reason for hiding this comment

tjwatson Feb 3, 2025

Choose a reason for hiding this comment

HannesWell Feb 5, 2025

Choose a reason for hiding this comment

tjwatson Feb 5, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 1, 2025

Test Results

HannesWell commented Feb 5, 2025