Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3647] Prometheus based limits check uses always port 9090 #3648

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[#3647] Prometheus based limits check uses always port 9090 #3648

merged 1 commit into from
Jun 21, 2024

Conversation

harism
Copy link
Contributor

@harism harism commented Jun 19, 2024

Read port value into separate Prometheus specific option with default value 9090 and use it to instantiate Prometheus config.

sophokles73
sophokles73 reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also extend PrometheusBasedResourceLimitCheckOptionsTest accordingly?

@harism harism force-pushed the fix_prometheus_port_config branch from 630121c to 0284ffe Compare June 20, 2024 16:28
@harism
Copy link
Contributor Author

harism commented Jun 20, 2024

Can you also extend PrometheusBasedResourceLimitCheckOptionsTest accordingly?

Done.

sophokles73
sophokles73 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for fixing this 👍

@sophokles73 sophokles73 merged commit a4f0e2f into eclipse-hono:master Jun 21, 2024
7 checks passed
@sophokles73 sophokles73 mentioned this pull request Jun 21, 2024
Closed
@harism harism deleted the fix_prometheus_port_config branch June 21, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophokles73 sophokles73 sophokles73 approved these changes

@dejanb dejanb Awaiting requested review from dejanb dejanb is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harism @sophokles73