[#3659] Add configurable cache refresh divisor to adjust cached item refresh time duration #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harism
force-pushed
the
prometheus_limits
branch
from
34e21ae
to
886b1c2
Compare
…cached item refresh time duration
harism
force-pushed
the
prometheus_limits
branch
from
886b1c2
to
5e7ff49
Compare
harism
changed the title
|
Changed this PR as agreed on issue [#3659] comments, and change the refresh time duration divisor configurable instead. |
sophokles73
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus based limit check does not give any wait time for reading cache misses, utilize the timeouts that Prometheus reads do have internally and use
CompletableFuture.get()without explicit timeout to wait and read the cache entry value.