-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1036 remove creation pattern #2017
Merged
elBoberido
merged 6 commits into
eclipse-iceoryx:master
from
elBoberido:iox-1036-remove-creation-pattern
Sep 6, 2023
Merged
iox-#1036 remove creation pattern #2017
elBoberido
merged 6 commits into
eclipse-iceoryx:master
from
elBoberido:iox-1036-remove-creation-pattern
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
changed the title
Iox 1036 remove creation pattern
iox-#1036 remove creation pattern
Sep 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #2017 +/- ##
==========================================
+ Coverage 74.17% 74.25% +0.07%
==========================================
Files 415 413 -2
Lines 16102 16054 -48
Branches 2254 2246 -8
==========================================
- Hits 11944 11921 -23
+ Misses 3435 3415 -20
+ Partials 723 718 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elBoberido
force-pushed
the
iox-1036-remove-creation-pattern
branch
from
September 2, 2023 11:30
5d9545d
to
527b9f9
Compare
elBoberido
added
refactoring
Refactor code without adding features
technical debt
unclean code and design flaws
labels
Sep 4, 2023
elBoberido
force-pushed
the
iox-1036-remove-creation-pattern
branch
from
September 4, 2023 15:02
61efc0a
to
d6c0562
Compare
…is started withoud a running roudi
elBoberido
force-pushed
the
iox-1036-remove-creation-pattern
branch
from
September 4, 2023 18:38
d6c0562
to
5a51c7c
Compare
FerdinandSpitzschnueffler
approved these changes
Sep 6, 2023
elfenpiff
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR builds upon #2016 which needs to be merged first. It removes the creation pattern fully and fixes the last remaining to-dos. If someone wants to review before the merge of #2016, the easiest way would be to check the last six commits.
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References