Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1036 remove creation pattern #2017

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 2, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR builds upon #2016 which needs to be merged first. It removes the creation pattern fully and fixes the last remaining to-dos. If someone wants to review before the merge of #2016, the easiest way would be to check the last six commits.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from elfenpiff September 2, 2023 10:24
@elBoberido elBoberido changed the title Iox 1036 remove creation pattern iox-#1036 remove creation pattern Sep 2, 2023
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #2017 (5a51c7c) into master (e70767a) will increase coverage by 0.07%.
Report is 10 commits behind head on master.
The diff coverage is 64.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
+ Coverage   74.17%   74.25%   +0.07%     
==========================================
  Files         415      413       -2     
  Lines       16102    16054      -48     
  Branches     2254     2246       -8     
==========================================
- Hits        11944    11921      -23     
+ Misses       3435     3415      -20     
+ Partials      723      718       -5     
Flag Coverage Δ
unittests 74.04% <64.43%> (+0.07%) ⬆️
unittests_timing 15.24% <28.03%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...include/iceoryx_dust/internal/cxx/forward_list.inl 0.00% <0.00%> (ø)
...ude/iceoryx_hoofs/internal/posix_wrapper/mutex.hpp 100.00% <ø> (ø)
iceoryx_hoofs/source/posix_wrapper/mutex.cpp 41.35% <ø> (-4.18%) ⬇️
.../posix_wrapper/shared_memory_object/memory_map.cpp 30.18% <ø> (+0.55%) ⬆️
...ude/iceoryx_posh/internal/mepoo/shared_pointer.hpp 100.00% <ø> (ø)
...ude/iceoryx_posh/internal/mepoo/typed_mem_pool.inl 82.85% <ø> (ø)
...ceoryx_dust/source/posix_wrapper/message_queue.cpp 61.90% <28.57%> (-1.37%) ⬇️
iceoryx_dust/source/posix_wrapper/named_pipe.cpp 49.43% <57.97%> (+0.40%) ⬆️
..._hoofs/source/posix_wrapper/unix_domain_socket.cpp 59.75% <63.10%> (+1.00%) ⬆️
...ude/iceoryx_posh/internal/mepoo/shared_pointer.inl 90.00% <71.42%> (+1.90%) ⬆️
... and 7 more

... and 1 file with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-1036-remove-creation-pattern branch from 5d9545d to 527b9f9 Compare September 2, 2023 11:30
@elBoberido elBoberido self-assigned this Sep 4, 2023
@elBoberido elBoberido added refactoring Refactor code without adding features technical debt unclean code and design flaws labels Sep 4, 2023
@elBoberido elBoberido force-pushed the iox-1036-remove-creation-pattern branch from 61efc0a to d6c0562 Compare September 4, 2023 15:02
@elBoberido elBoberido force-pushed the iox-1036-remove-creation-pattern branch from d6c0562 to 5a51c7c Compare September 4, 2023 18:38
@elBoberido elBoberido marked this pull request as ready for review September 4, 2023 18:38
@elBoberido elBoberido merged commit 9d32b95 into eclipse-iceoryx:master Sep 6, 2023
18 checks passed
@elBoberido elBoberido deleted the iox-1036-remove-creation-pattern branch September 6, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features technical debt unclean code and design flaws
Projects
None yet
3 participants