-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2011 Remove gcc 5.4 and std_header_check.sh from CI #2024
iox-#2011 Remove gcc 5.4 and std_header_check.sh from CI #2024
Conversation
…as minimal version
@dkroenke @mossmaurice There are still toolchain files for QNX 7.0. I can't update them to QNX 7.1 since I don't have access but also don't want to remove them since it might help someone else at porting. |
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
==========================================
- Coverage 74.27% 74.26% -0.01%
==========================================
Files 413 413
Lines 16055 16055
Branches 2246 2246
==========================================
- Hits 11925 11924 -1
Misses 3411 3411
- Partials 719 720 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📢 Have feedback on the report? Share it here. |
@elBoberido Could you create a issue for that and maybe add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
9ad8a59
to
e3e9efd
Compare
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR removes the GCC 5.4 CI check and std_header_check.sh
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References