Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2011 Remove gcc 5.4 and std_header_check.sh from CI #2024

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 7, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR removes the GCC 5.4 CI check and std_header_check.sh

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido
Copy link
Member Author

@dkroenke @mossmaurice There are still toolchain files for QNX 7.0. I can't update them to QNX 7.1 since I don't have access but also don't want to remove them since it might help someone else at porting.

@elBoberido elBoberido self-assigned this Sep 7, 2023
@elBoberido elBoberido added tooling All iceoryx related tooling (scripts etc.) technical debt unclean code and design flaws and removed technical debt unclean code and design flaws labels Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2024 (e3e9efd) into master (c5d1340) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2024      +/-   ##
==========================================
- Coverage   74.27%   74.26%   -0.01%     
==========================================
  Files         413      413              
  Lines       16055    16055              
  Branches     2246     2246              
==========================================
- Hits        11925    11924       -1     
  Misses       3411     3411              
- Partials      719      720       +1     
Flag Coverage Δ
unittests 74.05% <ø> (-0.01%) ⬇️
unittests_timing 15.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@mossmaurice
Copy link
Contributor

There are still toolchain files for QNX 7.0. I can't update them to QNX 7.1 since I don't have access but also don't want to remove them since it might help someone else at porting.

@elBoberido Could you create a issue for that and maybe add a @todo to the toolchain file?

mossmaurice
mossmaurice previously approved these changes Sep 7, 2023
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@elBoberido elBoberido force-pushed the iox-2011-remove-gcc-5.4-and-std-header-check branch from 9ad8a59 to e3e9efd Compare September 7, 2023 21:11
@elBoberido elBoberido merged commit 6bbdc6d into eclipse-iceoryx:master Sep 8, 2023
17 checks passed
@elBoberido elBoberido linked an issue Sep 8, 2023 that may be closed by this pull request
@elBoberido elBoberido deleted the iox-2011-remove-gcc-5.4-and-std-header-check branch September 8, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ongoing Issue: CI Maintenance Tasks
3 participants