Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include <chrono> for system_clock #2376

Closed
wants to merge 1 commit into from

Conversation

LilyWangLL
Copy link

@LilyWangLL LilyWangLL commented Nov 27, 2024

Notes for Reviewer

I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in iceoryx. It must add include <chrono> to fix this error.

Compiler error with this STL change:

D:\b\iceoryx\src\v2.0.6-c8abea20ae.clean\iceoryx_platform\win\source\time.cpp(42): error C2039: 'system_clock': is not a member of 'std::chrono'

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elfenpiff elfenpiff self-requested a review November 27, 2024 09:36
@elfenpiff
Copy link
Contributor

elfenpiff commented Nov 27, 2024

@LilyWangLL thanks for the pull request. Since iceoryx is a project for safety-critical systems as part of the eclipse foundation we have to follow some processes.

  1. Could you please sign the eclipse contributor agreement with the e-mail you have used to push your commits. See: https://www.eclipse.org/legal/eca/
  2. You have to always use the pull request template. I have adjusted it for you.
  3. Every pull request must be linked to an issue. I created the issue Fix windows performance issue #2377 for you.
  4. Every commit must be linked to the issue by using the prefix iox-#2377

As soon as the ECA is signed and you have added the prefix iox-#2377 to all commit messages we can merge this pull request.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (e693cc2) to head (9b2e75f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
- Coverage   78.70%   78.69%   -0.02%     
==========================================
  Files         440      440              
  Lines       16981    16981              
  Branches     2361     2361              
==========================================
- Hits        13365    13363       -2     
  Misses       2736     2736              
- Partials      880      882       +2     
Flag Coverage Δ
unittests 78.49% <ø> (-0.02%) ⬇️
unittests_timing 15.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@LilyWangLL
Copy link
Author

@LilyWangLL thanks for the pull request. Since iceoryx is a project for safety-critical systems as part of the eclipse foundation we have to follow some processes.

  1. Could you please sign the eclipse contributor agreement with the e-mail you have used to push your commits. See: https://www.eclipse.org/legal/eca/
  2. You have to always use the pull request template. I have adjusted it for you.
  3. Every pull request must be linked to an issue. I created the issue Fix windows performance issue #2377 for you.
  4. Every commit must be linked to the issue by using the prefix iox-#2377

As soon as the ECA is signed and you have added the prefix iox-#2377 to all commit messages we can merge this pull request.

Thanks for your reminder, I submitted a new PR which modified the branch name, please review the new PR #2378.

@LilyWangLL LilyWangLL closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix windows performance issue
2 participants