Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint_master.yml #2379

Open
wants to merge 2 commits into
base: release_2.0
Choose a base branch
from

Conversation

mosfet80
Copy link

@mosfet80 mosfet80 commented Dec 2, 2024

ubuntu 18.04 is not supported

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

  • Closes TBD

@elfenpiff
Copy link
Contributor

elfenpiff commented Dec 3, 2024

@mosfet80 Thank you for your contribution!

Since we are a mission-critical project we require that every commit corresponds to an issue so that we are able to trace every code change.

Could you please create an issue and then use the github issue number as a prefix for every commit message like iox-#???? commit message where ???? is the issue number.

You can do this by:

git rebase -i HEAD~2 # you have done 2 commits
# add `reword` in front of the commit messages of the opened editor and save it
# reword the commit messages
git push -f --force-with-lease

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (a4a1157) to head (b655f41).
Report is 1 commits behind head on release_2.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #2379      +/-   ##
===============================================
+ Coverage        78.47%   78.84%   +0.37%     
===============================================
  Files              370      370              
  Lines            14219    14715     +496     
  Branches          2060     2060              
===============================================
+ Hits             11158    11602     +444     
- Misses            2377     2430      +53     
+ Partials           684      683       -1     
Flag Coverage Δ
unittests 78.07% <ø> (+0.37%) ⬆️
unittests_timing 15.48% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 149 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants