Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#213] Add further tests #214

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented May 17, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #213

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (82b1baf) to head (1669eeb).
Report is 19 commits behind head on main.

Current head 1669eeb differs from pull request most recent head ed9363f

Please upload reports for the commit ed9363f to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   79.23%   79.60%   +0.37%     
==========================================
  Files         183      183              
  Lines       20415    20420       +5     
==========================================
+ Hits        16175    16255      +80     
+ Misses       4240     4165      -75     
Files Coverage Δ
iceoryx2-bb/posix/src/creation_mode.rs 100.00% <100.00%> (+60.00%) ⬆️

... and 61 files with indirect coverage changes

elBoberido
elBoberido previously approved these changes May 17, 2024
@elfenpiff elfenpiff marked this pull request as ready for review May 17, 2024 22:54
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add this badge to the main README

[![Codecov](https://codecov.io/gh/eclipse-iceoryx2/iceoryx/branch/main/graph/badge.svg?branch=main)](https://codecov.io/gh/eclipse-iceoryx/iceoryx2?branch=main)

}

#[test]
fn file_lock_try_and_timed_lock_fails_when_locked() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

food for thought: You could add a blocking test with a watchdog killing the test after the timeout and add the #[should_panic] attribute to the tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the read-write lock detects the deadlock and reports it, so there is no deadlock with the watchdog. But this could be added to the read-write lock test suite ...

README.md Outdated Show resolved Hide resolved
@elfenpiff elfenpiff force-pushed the iox2-213-increase-test-coverage branch 2 times, most recently from 4bcc4db to d2c9c1a Compare May 18, 2024 06:45
@elBoberido elBoberido force-pushed the iox2-213-increase-test-coverage branch from 1669eeb to ed9363f Compare May 20, 2024 17:08
@elfenpiff elfenpiff self-assigned this May 20, 2024
@elfenpiff elfenpiff requested a review from elBoberido May 20, 2024 18:05
@elfenpiff elfenpiff merged commit c1accf9 into eclipse-iceoryx:main May 20, 2024
46 of 47 checks passed
@elfenpiff elfenpiff deleted the iox2-213-increase-test-coverage branch May 20, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants