-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#213] Add further tests #214
[#213] Add further tests #214
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 79.23% 79.60% +0.37%
==========================================
Files 183 183
Lines 20415 20420 +5
==========================================
+ Hits 16175 16255 +80
+ Misses 4240 4165 -75
|
80dac92
to
cb692ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add this badge to the main README
[![Codecov](https://codecov.io/gh/eclipse-iceoryx2/iceoryx/branch/main/graph/badge.svg?branch=main)](https://codecov.io/gh/eclipse-iceoryx/iceoryx2?branch=main)
} | ||
|
||
#[test] | ||
fn file_lock_try_and_timed_lock_fails_when_locked() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
food for thought: You could add a blocking test with a watchdog killing the test after the timeout and add the #[should_panic]
attribute to the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the read-write lock detects the deadlock and reports it, so there is no deadlock with the watchdog. But this could be added to the read-write lock test suite ...
4bcc4db
to
d2c9c1a
Compare
1669eeb
to
ed9363f
Compare
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #213