Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#213] increase test container coverage #218

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented May 20, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #213

@elfenpiff elfenpiff requested a review from elBoberido May 20, 2024 21:40
@elfenpiff elfenpiff self-assigned this May 20, 2024
@elfenpiff elfenpiff force-pushed the iox2-213-increase-test-container-coverage branch from f601943 to dbbb0dc Compare May 20, 2024 21:42
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.03%. Comparing base (c1accf9) to head (e12486f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   79.59%   80.03%   +0.43%     
==========================================
  Files         183      183              
  Lines       20420    20423       +3     
==========================================
+ Hits        16254    16346      +92     
+ Misses       4166     4077      -89     
Files Coverage Δ
iceoryx2-bb/container/src/byte_string.rs 99.09% <100.00%> (+9.30%) ⬆️
iceoryx2-bb/container/src/semantic_string.rs 87.64% <100.00%> (+11.84%) ⬆️
iceoryx2-bb/posix/src/directory.rs 63.82% <100.00%> (ø)
iceoryx2-bb/posix/src/group.rs 71.92% <0.00%> (ø)

... and 12 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-213-increase-test-container-coverage branch from dbbb0dc to e12486f Compare May 20, 2024 23:47
@elfenpiff elfenpiff merged commit 07ee2f0 into eclipse-iceoryx:main May 21, 2024
49 checks passed
@elfenpiff elfenpiff deleted the iox2-213-increase-test-container-coverage branch May 21, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants