Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#264] Create infrastructure for C++ bindings #261

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jul 3, 2024

Notes for Reviewer

This PR adds the infrastructure to build the C++ bindings for iceoryx2.

Before this is merged

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #264

@elBoberido elBoberido force-pushed the iox2-210-create-infra-for-cpp-bindings branch 4 times, most recently from f8e3e92 to 4c422f7 Compare July 3, 2024 02:28
@elBoberido elBoberido force-pushed the iox2-210-create-infra-for-cpp-bindings branch from b302322 to 41fb917 Compare July 4, 2024 16:07
@elBoberido elBoberido force-pushed the iox2-210-create-infra-for-cpp-bindings branch from 1b77220 to 835194d Compare July 4, 2024 21:15
@elBoberido elBoberido force-pushed the iox2-210-create-infra-for-cpp-bindings branch from 835194d to 2325f25 Compare July 4, 2024 21:43
@elBoberido elBoberido force-pushed the iox2-210-create-infra-for-cpp-bindings branch 7 times, most recently from 3b8f3e8 to 6379225 Compare July 5, 2024 10:10
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (a83c2ec) to head (74833a5).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   79.79%   79.76%   -0.04%     
==========================================
  Files         191      191              
  Lines       21468    21468              
==========================================
- Hits        17130    17123       -7     
- Misses       4338     4345       +7     

see 5 files with indirect coverage changes

@elBoberido elBoberido force-pushed the iox2-210-create-infra-for-cpp-bindings branch from 6379225 to 10f0ada Compare July 5, 2024 15:24
@elBoberido elBoberido changed the title WIP [#210] Create infrastructure for C++ bindings [#210] Create infrastructure for C++ bindings Jul 5, 2024
@elBoberido elBoberido marked this pull request as ready for review July 5, 2024 15:25
@elBoberido elBoberido requested a review from elfenpiff July 5, 2024 15:55
@elBoberido elBoberido changed the title [#210] Create infrastructure for C++ bindings [#264] Create infrastructure for C++ bindings Jul 5, 2024
@elBoberido elBoberido self-assigned this Jul 5, 2024
- cmake -S examples/c -B target/ffi/out-of-tree-c -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH="$( pwd )/target/ffi/install;$( pwd )/target/iceoryx/install"
- cmake --build target/ffi/out-of-tree-c
- cmake -S examples/cxx -B target/ffi/out-of-tree-cxx -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH="$( pwd )/target/ffi/install;$( pwd )/target/iceoryx/install"
- cmake --build target/ffi/out-of-tree-cxx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a clang-format and clang-tidy CI check right from the beginning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved that task to a follow up to not block the C++ binding work

@elBoberido elBoberido merged commit 3f74aaa into eclipse-iceoryx:main Jul 8, 2024
51 checks passed
@elBoberido elBoberido deleted the iox2-210-create-infra-for-cpp-bindings branch July 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants