-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#264] Create infrastructure for C++ bindings #261
[#264] Create infrastructure for C++ bindings #261
Conversation
f8e3e92
to
4c422f7
Compare
b302322
to
41fb917
Compare
1b77220
to
835194d
Compare
835194d
to
2325f25
Compare
3b8f3e8
to
6379225
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
- Coverage 79.79% 79.76% -0.04%
==========================================
Files 191 191
Lines 21468 21468
==========================================
- Hits 17130 17123 -7
- Misses 4338 4345 +7 |
6379225
to
10f0ada
Compare
- cmake -S examples/c -B target/ffi/out-of-tree-c -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH="$( pwd )/target/ffi/install;$( pwd )/target/iceoryx/install" | ||
- cmake --build target/ffi/out-of-tree-c | ||
- cmake -S examples/cxx -B target/ffi/out-of-tree-cxx -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH="$( pwd )/target/ffi/install;$( pwd )/target/iceoryx/install" | ||
- cmake --build target/ffi/out-of-tree-cxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a clang-format and clang-tidy CI check right from the beginning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved that task to a follow up to not block the C++ binding work
Notes for Reviewer
This PR adds the infrastructure to build the C++ bindings for iceoryx2.
Before this is merged
v2.95.0
tag in iceoryx2.95.0
version infind_package
.clang-format
file -> Add clang-format and clang-tidy for C and C++ language bindings #265.clang-tidy
file -> Add clang-format and clang-tidy for C and C++ language bindings #265clang-tidy
andclang-format
-> Add clang-format and clang-tidy for C and C++ language bindings #265Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #264