Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#264] cxx language binding #276

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jul 10, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #264

@elfenpiff elfenpiff self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (f3350ea) to head (2f64c4c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   80.37%   80.37%   -0.01%     
==========================================
  Files         191      191              
  Lines       21814    21814              
==========================================
- Hits        17534    17533       -1     
- Misses       4280     4281       +1     

see 2 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-264-cxx-language-binding branch 7 times, most recently from a47b16d to e29ae70 Compare July 11, 2024 21:50
@elBoberido elBoberido force-pushed the iox2-264-cxx-language-binding branch from e86623e to 8706180 Compare July 11, 2024 23:04
@elfenpiff elfenpiff force-pushed the iox2-264-cxx-language-binding branch 3 times, most recently from 8390269 to c12de7d Compare July 12, 2024 23:01
@elfenpiff elfenpiff force-pushed the iox2-264-cxx-language-binding branch from 3d1ddcc to e08b1c3 Compare July 16, 2024 00:36
examples/c/publish_subscribe/src/publisher.c Outdated Show resolved Hide resolved
examples/cxx/complex_data_types/src/complex_data_types.cpp Outdated Show resolved Hide resolved
examples/cxx/event/src/notifier.cpp Outdated Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/node_name.hpp Outdated Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/node_state.hpp Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/service_builder.hpp Outdated Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/service_name.hpp Outdated Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/static_config.hpp Outdated Show resolved Hide resolved
…x::string instead of std::string; rule of 5 for resource classes; code cleanup
iceoryx2-ffi/cxx/include/iox2/attribute.hpp Show resolved Hide resolved
iceoryx2-ffi/cxx/include/iox2/node_name.hpp Outdated Show resolved Hide resolved
@elfenpiff elfenpiff merged commit 6c3ef94 into eclipse-iceoryx:main Jul 17, 2024
53 checks passed
@elfenpiff elfenpiff deleted the iox2-264-cxx-language-binding branch July 17, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants