Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3] Add cargo as dependency #344

Closed

Conversation

elfenpiff
Copy link
Contributor

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (67aefe3) to head (8025452).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   80.45%   80.44%   -0.02%     
==========================================
  Files         192      192              
  Lines       22495    22495              
==========================================
- Hits        18099    18096       -3     
- Misses       4396     4399       +3     

see 6 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-3-fix-mac-os-ci branch 2 times, most recently from d9fdaac to b1712e2 Compare August 5, 2024 07:55
@elBoberido
Copy link
Member

I also tried this on friday and reverted it since it didn't work.
It's also weird that there is no bug report in the repo of the action. Either everybody waits for anyone else to report the bug or we are for some reasons the only ones experiencing it.

@elfenpiff elfenpiff force-pushed the iox2-3-fix-mac-os-ci branch 3 times, most recently from ff45afa to 8025452 Compare August 5, 2024 10:53
@elBoberido elBoberido force-pushed the iox2-3-fix-mac-os-ci branch 2 times, most recently from d378f0d to d56163d Compare August 5, 2024 17:50
@elBoberido elBoberido force-pushed the iox2-3-fix-mac-os-ci branch 7 times, most recently from f417420 to 7f4ec3e Compare August 5, 2024 18:15
@elBoberido
Copy link
Member

fixed in #341

@elBoberido elBoberido closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants