Fix classes being 'lost' when earlier rounds of annotation processing succeed before a later round fails #3324
+21
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… succeed before a later round fails Specifically, when a later round of annotation processing fails with a `SourceTypeCollisionException` (i.e. generated type referenced before it has been created).
|
Please add a junit test as a separate commit that shows the error and gets solved by this commit. You can use this as sample: #1698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Annotation processing can fail with a
SourceTypeCollisionExceptionwhen a to-be generated type is referenced by an 'existing' source file. When this happens the compiler 'recompiles' the original files together with the newly generated files. The current implementation is buggy because annotation processing can go through multiple rounds, with each round generating new files. It is possible for earlier rounds to 'succeed', only for a later round to fail with aSourceTypeCollisionExceptionrequiring a restart. The current implementation 'loses' those files generated in earlier successful rounds.This PR fixes this issue by ensuring that files from earlier rounds are also included in the retry.
How to test
Unfortunately I only have a local project I am working on (which is how I discovered the bug). It's a WIP but I could make it available.
Author checklist