[GH-2620] consider the cursor location in completions #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing. The commit message does not match the recommendations for this repository. Please read |
I am not familiar with the options that you have for this repository but have seen that you can probably squash merge into master? So is it sufficient for me to push an empty commit that only contains the new commit message? |
|
A merge is possible but we typically use ammend or even create a new PR to also get the PR title updated.
Jörg Kubitz
… Am 26.11.2024 um 11:51 schrieb angelickite ***@***.***>:
Thanks for contributing. The commit message does not match the recommendations for this repository. Please read https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations
I am not familiar with the options that you have for this repository but have seen that you can probably squash merge into master? So is it sufficient for me to push an empty commit that only contains the new commit message?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
|
|
I have created a new pull request: #3350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add cursor awareness to various auto-completion situations.
Fixes #2620 specifically and probably also bug 575025, eclipse-jdt/eclipse.jdt.ui#1804, and probably some others.
How to test
I've included some tests. A thorough description can be found in #2620.
Author checklist