add Multistage dockerFile issue #1733 #1734
Open
+849
−718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1734 (2022-09-15T13:33:01Z) ⚙️ JKube E2E Tests (3060735726)
|
Signed-off-by Bramli Hamza <[email protected]>
|
@bramlihamza : Thanks a lot for PR 👍 Not sure why CircleCI checks are not running. Could you please try force pushing again? |
Hi, |
|
let me try to rebase and force push your changes |
rohanKanojia
force-pushed
the
issue1733
branch
from
b0b869e
to
12145f8
Compare
|
SonarCloud Quality Gate failed. |
Codecov Report
@@ Coverage Diff @@
## master #1734 +/- ##
============================================
+ Coverage 52.69% 52.86% +0.17%
- Complexity 3924 3935 +11
============================================
Files 461 464 +3
Lines 20752 20784 +32
Branches 2819 2819
============================================
+ Hits 10935 10988 +53
+ Misses 8693 8669 -24
- Partials 1124 1127 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bramlihamza
force-pushed
the
issue1733
branch
from
12145f8
to
06cc87b
Compare
rohanKanojia
reviewed
Sep 9, 2022
...it/config/image/src/test/java/org/eclipse/jkube/kit/config/image/ImageConfigurationTest.java
Outdated
Show resolved
Hide resolved
rohanKanojia
reviewed
Sep 9, 2022
...nfig/image/src/test/java/org/eclipse/jkube/kit/config/image/build/DockerFileBuilderTest.java
Outdated
Show resolved
Hide resolved
sunix
requested changes
Jan 26, 2023
| // in interpreted as a relative path to the exportDir | ||
| // See also http://docs.docker.io/reference/builder/#copy | ||
| private List<CopyEntry> copyEntries = new ArrayList<>(); | ||
| // List of files to add. Source and destination follow except that destination |
There was a problem hiding this comment.
It is too hard to spot out the differences with the code format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1733
Signed-off-by Bramli Hamza [email protected]
Type of change
test, version modification, documentation, etc.)
Checklist