-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DockerImage Kind in BuildOutput #710
Add DockerImage Kind in BuildOutput #710
Conversation
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
============================================
+ Coverage 45.01% 45.03% +0.01%
- Complexity 3127 3134 +7
============================================
Files 413 413
Lines 19645 19657 +12
Branches 2761 2764 +3
============================================
+ Hits 8843 8852 +9
- Misses 9791 9793 +2
- Partials 1011 1012 +1
Continue to review full report at Codecov.
|
52b15fb
to
bfda760
Compare
c499b54
to
e69a651
Compare
e69a651
to
0325f70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
.../src/test/java/org/eclipse/jkube/kit/config/service/openshift/OpenshiftBuildServiceTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/eclipse/jkube/kit/config/service/openshift/OpenshiftBuildServiceTest.java
Outdated
Show resolved
Hide resolved
…onfig/service/openshift/OpenshiftBuildServiceTest.java Co-authored-by: Rohan Kumar <[email protected]>
…onfig/service/openshift/OpenshiftBuildServiceTest.java Co-authored-by: Rohan Kumar <[email protected]>
SonarCloud Quality Gate failed. |
Description
Address the issue defined fabric8io/fabric8-maven-plugin#1054
Type of change
test, version modification, documentation, etc.)
Checklist